Skip to content

test(firestore): fix flaky BulkWriter thread tests #34609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aandreassa wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −7
Open

test(firestore): fix flaky BulkWriter thread tests #34609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions google-cloud-firestore/test/google/cloud/firestore/bulkwriter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,17 +209,20 @@
stub = BatchWriteStub.new responses, requests, 1
firestore.service.instance_variable_set :@firestore, stub

thread_count = Thread.list.count
bw = firestore.bulk_writer request_threads: 1, batch_threads: 2

result_1 = bw.create "cities/NYC", { foo: "bar"}
result_2 = bw.create "cities/MTV", { foo: "bar"}
result_3 = bw.create "cities/KIR", { foo: "bar"}
bw.flush
thread_count_2 = Thread.list.count

write_tp = bw.instance_variable_get(:@write_thread_pool)
batch_tp = bw.instance_variable_get(:@scheduler).instance_variable_get(:@batch_thread_pool)
_(write_tp.max_length).must_equal 1
_(batch_tp.max_length).must_equal 2

bw.close

_(thread_count_2 - thread_count).must_be :==, 3
_(result_1.value).must_be_kind_of Google::Cloud::Firestore::BulkWriterOperation::WriteResult
_(result_2.value).must_be_kind_of Google::Cloud::Firestore::BulkWriterOperation::WriteResult
_(result_3.value).must_be_kind_of Google::Cloud::Firestore::BulkWriterOperation::WriteResult
Expand All @@ -231,18 +234,19 @@
stub = BatchWriteStub.new [], [], 1
firestore.service.instance_variable_set :@firestore, stub

thread_count = Thread.list.count
bw = firestore.bulk_writer batch_threads: 3, request_threads: 1, retries: 1

(1..100).each do
bw.create "cities/#{SecureRandom.hex(4)}", { foo: "bar"}
end
bw.flush
thread_count_2 = Thread.list.count

bw.close
write_tp = bw.instance_variable_get(:@write_thread_pool)
batch_tp = bw.instance_variable_get(:@scheduler).instance_variable_get(:@batch_thread_pool)
_(write_tp.max_length).must_equal 1
_(batch_tp.max_length).must_equal 3

_(thread_count_2 - thread_count).must_be :==, 4
bw.close
end
end

Expand Down
Loading