tests: fix Kokoro change detection#8510
Open
jskeet wants to merge 8 commits into
Open
Conversation
Previously we'd be checking for a change in a subdirectory handwritten/xyz while already *in* handwritten/xyz, which is clearly wrong. After this change, we just check for a change within the current directory.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies several Kokoro trampoline scripts to change the RELATIVE_PKG_PATH variable from hardcoded package paths to ".". However, because the scripts execute a cd to the repository root prior to this check, setting the path to "." will cause the change detection mechanism to check the entire repository instead of the specific package. This defeats the purpose of the conditional test execution. The reviewer recommends reverting these changes across all affected scripts to preserve correct package-specific change detection.
Previously we'd be checking for a change in a subdirectory handwritten/xyz while already *in* handwritten/xyz, which is clearly wrong. After this change, we just check for a change within the current directory.
jskeet
force-pushed
the
fix-change-detection
branch
from
ab8541e to
091aeee
Compare
jskeet
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
jskeet
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
feywind
approved these changes
Jun 10, 2026
|
|
||
| /** | ||
| * Discovery Revision: 20260328 | ||
| * Discovery Revision: 20260429 |
Contributor
There was a problem hiding this comment.
I suspect these were unintentional(?) but should be harmless to throw in here.
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we'd be checking for a change in a subdirectory handwritten/xyz while already in handwritten/xyz, which is clearly wrong. After this change, we just check for a change within the current directory.