tests(Diagnostics): Loosen some tests that flake because of data freshness#15663
Merged
Merged
Conversation
…Core3 solution. We reuse code from Commnon.IntegrationTests in AspNetCore3.IntegrationTests and this just makes it easier to change things at once.
We ocassionally see some flakes due to data freshness.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates integration tests and solution configurations. Specifically, it relaxes the assertion in LoggingTest.cs to expect between 950 and 1000 log entries instead of exactly 1000 to account for data freshness. It also adds the Google.Cloud.Diagnostics.Common.IntegrationTests project to the AspNetCore3 solution file, and sets a default timeout of 15 minutes for ErrorEventEntryPolling. There are no review comments, and I have no feedback to provide.
efevans
reviewed
Jun 11, 2026
Contributor
|
LGTM |
efevans
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.