chore(Renovate): Update Renovate config names#15662
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request attempts to enable Renovate configuration migration in both .github/renovate.json and generator-input/renovate-template.json by adding ':configMigration' to the extends array. However, configMigration is a top-level boolean configuration option rather than a preset, and adding it to extends will cause a validation error. It is recommended to define it as a top-level property 'configMigration': true instead.
This is not possible. But, can you check if |
efevans
force-pushed
the
renovate/config-migration
branch
3 times, most recently
from
30b4bbc to
de7a746
Compare
| { | ||
| "extends": [ | ||
| "config:base", | ||
| "config:recommended", |
There was a problem hiding this comment.
But this template won't be automatically updated, correct? Any time we see a PR coming in for renovate.json with a changed field name we'd need to push a similar PR for the template? We can live with that I think, I want to understand it though.
Did you look into having two files one including the other?
There was a problem hiding this comment.
Correct it won't be updated. I made a change in commits and overall suggestion to do a one-time update based on a local dry run with. Specifically I ran with :configMigration and then took the changes and applied them manually. See my comment below, but the short is that we'd need a separate repo to host a second config and extend from it to use two files, per the Renovate docs.
There was a problem hiding this comment.
I think it can be in our own repo, we just have to add the fully qualified name of the repo before the file name. That's fine though and I don't think this will happen so often that we have to make many changes, and we shouldn't invest much in having the perfect renovate config. Let's just change the ones that we know of now as you are doing and call it day.
| { | ||
| "extends": [ | ||
| "config:base", | ||
| "config:recommended", |
There was a problem hiding this comment.
What else changes from base to recommended?
There was a problem hiding this comment.
base is deprecated and their docs maintain any references to it. From what I can tell from looking around and asking Gemini, the they are similar and you can see what recommended does here. recommended will also be supported so it's presets may change in the future as the Renovate team updates their idea of best practices.
There was a problem hiding this comment.
Let's not make this change then until we know we have time to test it.
|
@amanda-tarafa Looks like you can use a file as a preset but that requires hosting this preset in a separate git repo. I'd suggest we do a one-time update of configs and leave this as done for the purposes of the Fixit. The current changes are taking a local dry run and applying its suggested config. One thing to notice is the the original comment here is not an updated config name. These do separate but similar things, with the |
efevans
changed the title
| { | ||
| "extends": [ | ||
| "config:base", | ||
| "config:recommended", |
There was a problem hiding this comment.
Let's not make this change then until we know we have time to test it.
| { | ||
| "extends": [ | ||
| "config:base", | ||
| "config:recommended", |
There was a problem hiding this comment.
I think it can be in our own repo, we just have to add the fully qualified name of the repo before the file name. That's fine though and I don't think this will happen so often that we have to make many changes, and we shouldn't invest much in having the perfect renovate config. Let's just change the ones that we know of now as you are doing and call it day.
efevans
force-pushed
the
renovate/config-migration
branch
from
de7a746 to
4bc38c7
Compare
|
@amanda-tarafa Reverted to |
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
And also see if these need to be done in the other repos.
2 participants
b/521971428
This config change will have Renovate create PRs with up-to-date option names. We regenerate the renovate config
ReleaseManager, using the template so once "the most up-to-date" option names change again, renovate will update it's own configs at/.github/renovate.json, which will be overwritten byReleaseManagerand likely continue in a cycle. Need to think what to do here, we could commit these changes and let them run as a one-time change, and mirror those changes over to the template. Or we could figure how to remove renovate regeneration inReleaseManager, if that's even possible right now.