feat: add HTTP retry support#789
Open
xiantank wants to merge 2 commits into
Open
Conversation
Add HTTPRetryOptions to HTTPOptions so callers can configure automatic retries on transient failures (network errors and retriable HTTP status codes). Mirrors the Python SDK's HttpRetryOptions behavior, with the same defaults (5 attempts, exponential backoff 1s -> 60s, jitter 1s, retriable codes 408/429/500/502/503/504). Retry is opt-in: HTTPOptions.RetryOptions defaults to nil which keeps existing behavior unchanged. Both client-level and per-request override are supported via patchHTTPOptions.
Previously the cap was applied before adding jitter, so the effective maximum delay was MaxDelay + Jitter (e.g. 61s with the defaults). Apply the cap after jitter so the configured MaxDelay is the actual upper bound, matching the Python SDK's HttpRetryOptions semantics (tenacity.wait_exponential_jitter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #713.
The Python SDK exposes
HttpRetryOptionsfor opt-in HTTP retries; the Go SDK currently has none. This adds the equivalentHTTPRetryOptionsonHTTPOptions, mirroring the Python implementation.Behavior:
net.ErrorsHTTPOptions.RetryOptionsdefaults tonil, so existing behavior is unchanged. Both client-level and per-request overrides are supported.