test: poll the emulator to ensure it is ready before proceeding#747
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces static delays with a robust WaitUntilReady polling mechanism to verify that the Spanner emulator is fully started before returning. The reviewer feedback suggests removing an unused System.Net.Sockets import and avoiding modifying the global SPANNER_EMULATOR_HOST environment variable. Instead, specifying the host and port directly in the connection string is recommended to prevent potential race conditions during concurrent test execution.
olavloite
force-pushed
the
emulator-polling
branch
3 times, most recently
from
08ae93f to
c586c19
Compare
Poll the Emulator to ensure it is actually running before proceeding with the test or sample.
olavloite
force-pushed
the
emulator-polling
branch
from
c586c19 to
bf90ed5
Compare
sakthivelmanii
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poll the Emulator to ensure it is actually running before proceeding with the test or sample.