impl(bq_driver): Add Log macros in bq_drvier/internal dir second pr#1172
Merged
Conversation
NeerajDwivedii
changed the title
Collaborator
Author
|
/gcbrun |
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
66065c8 to
987e0f1
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
987e0f1 to
c6ee887
Compare
NeerajDwivedii
changed the title
Collaborator
Author
|
@sachinpro PR ready for review |
NeerajDwivedii
force-pushed
the
trace_logging_impl
branch
4 times, most recently
from
1c2f9ef to
17d6bc6
Compare
sachinpro
force-pushed
the
trace_logging_impl
branch
from
17d6bc6 to
ac8095f
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
c6ee887 to
4738fd6
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
4738fd6 to
d6d19a2
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
d6d19a2 to
69e3023
Compare
Collaborator
Author
|
Added log tracing fix through connection string, adds google.googlebigqueryodbc.ini, and include test case for same |
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
69e3023 to
06cae48
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
06cae48 to
f7d228d
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
f7d228d to
99d004f
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
99d004f to
0f97390
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
0f97390 to
c3e525a
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
c3e525a to
26390e8
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
26390e8 to
cc6d35e
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
cc6d35e to
bc5fe02
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
bc5fe02 to
80a55e7
Compare
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
80a55e7 to
44dabf8
Compare
NeerajDwivedii
temporarily deployed
to
internal
GitHub Actions
Inactive
NeerajDwivedii
force-pushed
the
Log_trace_macros_5
branch
from
44dabf8 to
c662cbb
Compare
NeerajDwivedii
temporarily deployed
to
internal
GitHub Actions
Inactive
Collaborator
Author
|
This PR should be merged after the following PR: #1173 |
sachinpro
approved these changes
Aug 14, 2025
sachinpro
left a comment
sachinpro
left a comment
Collaborator
There was a problem hiding this comment.
Lets enhance ConnectionTest.CheckTraceLogFileExist to verify the contents of the file. Maybe check one error line by forcing error during Connect and validate by grepping into the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added log macros
(ERROR, INFO, WARNING)inbq_driver/internaldirectory files. This is second pr of bq_driver/internal dir.