fix(aes): validate key generation lengths - #404
Open
harrshita123 wants to merge 1 commit into
Open
harrshita123 wants to merge 1 commit into
harrshita123 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #403.
Validate AES key-generation lengths at the shared Dart API boundary before dispatching to native or browser implementations.
This ensures that AES-CBC, AES-CTR, and AES-GCM consistently reject invalid lengths with
FormatException, without exposing raw JavaScriptTypeErrorobjects on browser backends. The existingUnsupportedErrorbehavior for 192-bit AES keys is preserved.Regression coverage includes all three AES APIs on the VM, Chrome Dart2JS, and Chrome Dart2Wasm.
Tests
dart analyze --fatal-warnings .dart test test/webcrypto_test.dart -p vmdart test test/webcrypto_test.dart -p chrome --compiler dart2jsdart test test/webcrypto_test.dart -p chrome --compiler dart2wasm