Skip to content

docs: extract RSA-OAEP PKCS#8 import example - #398

Open
Tiancheng-Xu wants to merge 2 commits into
google:masterfrom
Tiancheng-Xu:docs/rsa-oaep-import-pkcs8-example
Open

Tiancheng-Xu wants to merge 2 commits into
google:masterfrom
Tiancheng-Xu:docs/rsa-oaep-import-pkcs8-example

Conversation

@Tiancheng-Xu

Copy link
Copy Markdown

Summary

  • Move the existing RsaOaepPrivateKey.importPkcs8Key dartdoc example to example/webcrypto/rsa_oaep/import_pkcs8_key.dart.
  • Replace the inline block with the corresponding {@example ...#example} directive.
  • Preserve the example behavior and keep the change limited to this method.

Part of #283.

Validation

  • git diff --check
  • Structural extraction check: example body preserved, reference appears once, old inline block removed, region markers balanced, and Apache license header present.
  • dart format and dart analyze were not run locally because Dart/Flutter are not installed in the environment; upstream CI will provide the repository toolchain validation.

Comment thread example/webcrypto/rsa_oaep/import_pkcs8_key.dart
@Tiancheng-Xu

Copy link
Copy Markdown
Author

Follow-up: CI now passes check-changes and cla/google on commit 49a4fd2. The extracted example imports package:pem/pem.dart, so I added pem: ^2.0.6 under dev_dependencies; this keeps the package runtime dependency surface unchanged while allowing dart analyze to resolve the example. Could you please re-review the updated commit?

@Tiancheng-Xu

Copy link
Copy Markdown
Author

Follow-up verified: pem: ^2.0.6 is now present under dev_dependencies, so the extracted example resolves PemCodec/PemLabel without expanding runtime dependencies. Current visible checks (check-changes, cla/google) pass; the earlier Format + Lints failure was from the prior run and is no longer present in the current check set.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants