fix(kdf): validate deriveBits output length - #390
Open
harrshita123 wants to merge 1 commit into
Open
harrshita123 wants to merge 1 commit into
harrshita123 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #389.
Summary
deriveBitslengths before backend dispatchunsigned longrangeRoot cause
The browser backend forwarded arbitrary Dart integers to
SubtleCrypto.deriveBits. Web IDL converted those values tounsigned long, so inputs such as-0xfffffff8wrapped to8and produced a one-byte result instead of failing.The shared validation also prevents oversized PBKDF2 output lengths from reaching the native allocation path.
Validation
dart analyze --fatal-warnings .git diff --check