Skip to content

k8s.io and knative.dev/pkg upgrade#1116

Merged
balamut-google merged 11 commits into
mainfrom
k8s_upgrade
Jun 25, 2026
Merged

k8s.io and knative.dev/pkg upgrade#1116
balamut-google merged 11 commits into
mainfrom
k8s_upgrade

Conversation

@balamut-google

@balamut-google balamut-google commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Upgrade of k8s.io and knative.dev/pkg dependencies.

Summary of changes

  • Bumped up versions of k8s.io/api an related modules to 0.36.2 + transitive dependencies
  • Bumped up knative.dev/pkg to v0.0.0-20260615201544-6300c57a9e78 + transitive dependencies
  • Changed hack/update-codegen.sh scripts to conform to parameters and flag names or 0.36.2 version of k8s code generators
  • Regenerated code using new version of code generators (pkg/client +pkg/apis)
  • Updated "golden" test data (mostly removal of empty creationTimestamp)
  • Removed Reporter field from knative.dev/pkg's ControllerOptions as it was removed (multiple Kf controllers)
  • Replaced usages of already removed knative.dev/pkg/metrics with up-to-date packages
  • Replaced usages of github.com/emicklei/go-restful with github.com/emicklei/go-restful/v3
  • Added assignment to EffectiveVersion property in first_party/k8s-stateless-subresource/pkg/apiserver/apiserver.go - this field is now mandatory in API server implementation

@balamut-google balamut-google requested a review from bryk June 24, 2026 14:19

@bryk bryk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green. Huge lift on the K8s 0.36.2 bump.

Just hit me with a quick sanity check before merging:

Controller Metrics: Did the removal of Reporter leave any blind spots in our observability?

go-restful v3: Confident that routing and middleware filters didn't break with the major version bump?

If those are solid, you are good to go.

@balamut-google balamut-google changed the title K8s upgrade k8s.io and knative.dev/pkg upgrade Jun 25, 2026
@balamut-google

Copy link
Copy Markdown
Contributor Author

LGTM once CI is green.

Automated tests are now green.

Just hit me with a quick sanity check before merging:

Controller Metrics: Did the removal of Reporter leave any blind spots in our observability?

The reported metrics are aggregated performance data for controller loops, lack of these does not impact ability to troubleshoot potential individual processing failures. knative.dev/pkg now exposes this data to OpenTelemetry Collector, but Kf is not exporting them.

go-restful v3: Confident that routing and middleware filters didn't break with the major version bump?
This is necessary due to k8s.io upgrade, v3 is written by the same author(s) and has the same API as previous version (v2).

If those are solid, you are good to go.

@balamut-google balamut-google merged commit 845464d into main Jun 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants