k8s.io and knative.dev/pkg upgrade#1116
Conversation
Upgraded knative.dev/pkg modules to more recent version.
bryk
left a comment
There was a problem hiding this comment.
LGTM once CI is green. Huge lift on the K8s 0.36.2 bump.
Just hit me with a quick sanity check before merging:
Controller Metrics: Did the removal of Reporter leave any blind spots in our observability?
go-restful v3: Confident that routing and middleware filters didn't break with the major version bump?
If those are solid, you are good to go.
Automated tests are now green.
The reported metrics are aggregated performance data for controller loops, lack of these does not impact ability to troubleshoot potential individual processing failures.
|
Upgrade of
k8s.ioandknative.dev/pkgdependencies.Summary of changes
k8s.io/apian related modules to0.36.2+ transitive dependenciesknative.dev/pkgtov0.0.0-20260615201544-6300c57a9e78+ transitive dependencieshack/update-codegen.shscripts to conform to parameters and flag names or0.36.2version ofk8scode generatorspkg/client+pkg/apis)creationTimestamp)Reporterfield from knative.dev/pkg'sControllerOptionsas it was removed (multiple Kf controllers)knative.dev/pkg/metricswith up-to-date packagesgithub.com/emicklei/go-restfulwithgithub.com/emicklei/go-restful/v3EffectiveVersionproperty infirst_party/k8s-stateless-subresource/pkg/apiserver/apiserver.go- this field is now mandatory in API server implementation