lattigo: lattigo.bootstrap needs ResetsLevelOpInterface#3226
Open
AlexanderViand wants to merge 1 commit into
Open
lattigo: lattigo.bootstrap needs ResetsLevelOpInterface#3226AlexanderViand wants to merge 1 commit into
AlexanderViand wants to merge 1 commit into
Conversation
Draft
asraa
approved these changes
Jul 22, 2026
asraa
left a comment
Collaborator
There was a problem hiding this comment.
while i know this is right (hence lgtm).. it broke my compilation of lenet when i patched it :|
j2kun
approved these changes
Jul 22, 2026
Collaborator
|
It looks like this PR still has |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driven by #3225, where I ran into
The bug had a really simple fix (
lattigo.bootstrapseems to have lost its level-analysis annotation when we switched from ResetsMulDepthOpInterface to ResetsLevelOpInterface) but really annoying to track down. As a result of the missing level reset annotation,AllocToInplacethought that a mul op after a bootstrap was still happening at basically level 0, so tried to re-use level-0 buffers for them. Lattigo, in its wisdom, would not throw an error upon using a too-small/too-low-level output buffer, but instead just force things down to level 0 and hence in the next step, we'd get an attempt to rescale a level 0 ciphertext 🤦