Support RNS for coeff-form multiplication#3222
Merged
Merged
Conversation
crockeea
marked this pull request as draft
July 21, 2026 17:39
j2kun
approved these changes
Jul 21, 2026
j2kun
added
the
pull_ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR's main goal was to address #3061, which in itself is not particularly useful since we don't expect to actually do COEFF-form multiplication ever. However, in the process of fixing that issue, this PR addresses other [actually useful] gaps:
polynomial.constantfor RNS types (though still notRNSPolynomialAttr)LeadingTermOpnow works for RNS polynomialsIt may also make progress on #1199.
Assisted by AI