[FoldConstantTensors] Set insertion point after last operation to erase#3130
Open
VedantParanjape wants to merge 1 commit into
Open
[FoldConstantTensors] Set insertion point after last operation to erase#3130VedantParanjape wants to merge 1 commit into
VedantParanjape wants to merge 1 commit into
Conversation
InsertIntoFromElements rewrite pattern emits the new FromElementsOp after the first InsertOp. This creates dominance issues if there are SSA values defined after the first InsertOp. The following snippet depicts the issue with the current implementation. This patch sets an insertion point after the last InsertOp to fix the dominance issue. ``` %ext0 = tensor.extract %input[idx0] %ins1 = tensor.insert %ext0 into %zero[...] %ext2 = tensor.extract %input[idx2] %ins3 = tensor.insert %ext2 into %ins1[...] ``` ``` /local/scratch/a/heir/kernel-mm4.mlir:12:12: note: operand defined here (op in the same block) /local/scratch/a/heir/kernel-mm4.mlir:11:12: error: operand google#8 does not dominate this use ```
j2kun
approved these changes
Jun 26, 2026
j2kun
added
the
pull_ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InsertIntoFromElements rewrite pattern emits the new FromElementsOp after the first InsertOp. This creates dominance issues if there are SSA values defined after the first InsertOp. The following snippet depicts the issue with the current implementation. This patch sets an insertion point after the last InsertOp to fix the dominance issue.