Remove unused LLVM inliner interface from heir-opt.#3119
Merged
Conversation
2df90c9 to
f7be72a
Compare
Remove the unused LLVM inliner interface registration from `heir-opt` and remove the `LLVMIRTransforms` dependency to break the dependency path to `NVVMDialect`. The LLVM dialect promises this interface, so I added a dummy interface implementation (we don't use it, so it doesn't matter what we use for the implementation). Part of #3114 PiperOrigin-RevId: 937968954
f7be72a to
347e801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused LLVM inliner interface from heir-opt.
Remove the unused LLVM inliner interface registration from
heir-optand remove theLLVMIRTransformsdependency to break the dependency path toNVVMDialect.The LLVM dialect promises this interface, so I added a dummy interface implementation (we don't use it, so it doesn't matter what we use for the implementation).
Part of #3114