split-preprocessing: use new preprocessing dialect infrastructure#3060
Open
copybara-service[bot] wants to merge 1 commit into
Open
split-preprocessing: use new preprocessing dialect infrastructure#3060copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_929352045
branch
2 times, most recently
from
f1625b8 to
05797e7
Compare
copybara-service
Bot
force-pushed
the
test_929352045
branch
3 times, most recently
from
48c85c0 to
bbbc9ef
Compare
Collaborator
|
Asra reviewed it internally and so I'll go ahead and merge |
Collaborator
👍 Yeah, sorry, I've been busy chasing down cheddar backend bugs and haven't had a chance to play around with it yet |
This change modifies split-preprocessing to use the new preprocessing dialect for its output, and updates the pipelines to use preprocessing-to-memref. It changes the `split-preprocessing` flag from a numeric batching factor to a boolean enable/disable. It also adds a small amount of fixes to the lattigo lowering (which otherwise supports bufferization and memrefs). Fixes #2960 PiperOrigin-RevId: 929352045
copybara-service
Bot
force-pushed
the
test_929352045
branch
from
bbbc9ef to
81e0352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split-preprocessing: use new preprocessing dialect infrastructure
This change modifies split-preprocessing to use the new preprocessing dialect for its output, and updates the pipelines to use preprocessing-to-memref.
It changes the
split-preprocessingflag from a numeric batching factor to a boolean enable/disable. It also adds a small amount of fixes to the lattigo lowering (which otherwise supports bufferization and memrefs).Fixes #2960