Skip to content

Fix hermetic toolchain#3048

Merged
copybara-service[bot] merged 1 commit into
google:mainfrom
j2kun:hermetic-llvm
Jun 23, 2026
Merged

Fix hermetic toolchain#3048
copybara-service[bot] merged 1 commit into
google:mainfrom
j2kun:hermetic-llvm

Conversation

@j2kun

@j2kun j2kun commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Fixes #3047

A simplification and borrowing parts of #3045

Change summary:

  1. Bump hermetic llvm to a version that has openmp
  2. Patch openfhe locally to pull from the hermetic llvm's openmp
  3. Bump fmt to a working version
  4. Move zlib to MODULE.bazel to avoid the need to patch
  5. Patch bison same as LLM-generated hermetic llvm #3045
  6. Use @hermetic_llvm//openmp:libomp in the places in HEIR that need openmp
  7. Enable BAZEL_TRACK_SOURCE_DIRECTORIES to silence some warnings introduced by hermetic llvm (this will go away by default in bazel 9, but we're still on bazel 8)
  8. Add -no-pie for golang tests
  9. Enable remote build execution and caching with buildbuddy, but don't yet update main CI workflow to use it.

@j2kun j2kun requested a review from AlexanderViand June 9, 2026 18:42
@j2kun j2kun added ci:macos Run the MacOS CI on this PR ci:wheels labels Jun 9, 2026
@j2kun j2kun removed the request for review from AlexanderViand June 9, 2026 19:53
@j2kun j2kun marked this pull request as draft June 9, 2026 19:53
@j2kun j2kun changed the title Fix non-frontend parts of hermetic toolchain Fix hermetic toolchain Jun 9, 2026
copybara-service Bot pushed a commit that referenced this pull request Jun 18, 2026
copybara-service Bot pushed a commit that referenced this pull request Jun 18, 2026
@j2kun j2kun marked this pull request as ready for review June 22, 2026 15:38
@j2kun j2kun requested a review from asraa June 22, 2026 15:38
@j2kun j2kun force-pushed the hermetic-llvm branch 4 times, most recently from 68c11cd to 7b0021c Compare June 22, 2026 16:23
@j2kun j2kun removed ci:macos Run the MacOS CI on this PR ci:wheels labels Jun 22, 2026
@j2kun j2kun force-pushed the hermetic-llvm branch 2 times, most recently from 3bba41f to 4f912ad Compare June 22, 2026 17:26
Co-authored-by: Alexander Viand <alexander.viand@gmail.com>
Comment thread .bazelrc

@asraa asraa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick questions

Comment thread tools/BUILD
@j2kun j2kun added the ci:macos Run the MacOS CI on this PR label Jun 22, 2026
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Jun 22, 2026
@j2kun

j2kun commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

The macos build ran out of memory, so this suggests the openmp was not blocking the build. I think buildbuddy will reduce RAM needs for the macos CI when it's working

@copybara-service copybara-service Bot merged commit 6f08617 into google:main Jun 23, 2026
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:macos Run the MacOS CI on this PR pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly enable the hermetic C++ toolchain

2 participants