add bufferization-preparation passes to lattigo pipeline#3001
Merged
copybara-service[bot] merged 1 commit intoMay 29, 2026
Merged
Conversation
j2kun
approved these changes
May 29, 2026
j2kun
left a comment
j2kun
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! I think I discovered this while working on something similar today where arith.truncf was not supported
j2kun
added
the
pull_ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bufferization is pretty picky about what ops it will support, for example it does not accept
arithf.add %t1, %t2 : tensor<...>but instead wants thelinalg.genericversion. We already do this in other bufferization-using pipelines, this PR simply gives that set of passes a nice name/helper and adds it to the lattigo pipeline, too.PS: Sorry for the piece-meal PRs, I didn't realize the rabbit hole I'd be going down as part of rebasing our stuff onto the new bufferized lattigo backend