Skip to content

support DenseResourceElementsAttr in memref'ed lattigo emitter#2999

Merged
copybara-service[bot] merged 1 commit into
google:mainfrom
AlexanderViand:lattigo-dense-resource-elements-attrs
Jun 18, 2026
Merged

support DenseResourceElementsAttr in memref'ed lattigo emitter#2999
copybara-service[bot] merged 1 commit into
google:mainfrom
AlexanderViand:lattigo-dense-resource-elements-attrs

Conversation

@AlexanderViand

Copy link
Copy Markdown
Collaborator

Missing support for model weights in dense resources popped up when we rebased our internal ML pipeline onto the new bufferizied lattigo emitter. 🤖-generated fix.

@AlexanderViand AlexanderViand requested a review from j2kun May 28, 2026 08:33

@asraa asraa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some test coverage for this please?

@j2kun j2kun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, looks great but just add a small lit test so it doesn't get refactored into oblivion.

@AlexanderViand AlexanderViand force-pushed the lattigo-dense-resource-elements-attrs branch from d0327d5 to 1a01493 Compare May 29, 2026 12:27

@j2kun j2kun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I missed that this got updated until the morning of the WG meeting. LGTM!

@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Jun 18, 2026
@copybara-service copybara-service Bot merged commit b222d1c into google:main Jun 18, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants