Add test for non square filter#2986
Merged
copybara-service[bot] merged 1 commit intoMay 26, 2026
Merged
Conversation
asraa
approved these changes
May 26, 2026
asraa
left a comment
asraa
left a comment
Collaborator
There was a problem hiding this comment.
thank you! is there any way you can try out another test point - maybe something on the domain coordinate (1, 0, 1, 2) (h != w != 0)?
but thank you so much for adding this test!
add point check
mdgrs
force-pushed
the
mdgrs/nonSquareFilterPermutation
branch
from
May 26, 2026 15:20
a50df00 to
13d2596
Compare
Collaborator
Author
|
I added a point check as a sanity check |
asraa
added
the
pull_ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a mistake in the row interchange permutation computation.