Skip to content

Resolve TODOs from #2157#2977

Merged
copybara-service[bot] merged 1 commit into
google:mainfrom
crockeea:fix_2157
Jun 3, 2026
Merged

Resolve TODOs from #2157#2977
copybara-service[bot] merged 1 commit into
google:mainfrom
crockeea:fix_2157

Conversation

@crockeea

Copy link
Copy Markdown
Collaborator

It's unclear if this actually resolves #2157. The TODOs from that issue are no longer relevant, and have been removed. But that issue also mentions

  • getting the key switching key added to the IR at a higher level
  • getting parameter-selected params forwarded to this lowering

neither of which are done.

@j2kun

j2kun commented May 21, 2026

Copy link
Copy Markdown
Collaborator

It appears there is a related test failure. Also happy to chat live or email about the next steps

@crockeea

crockeea commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

The test failure is related to a test which was previously disabled, and which, with this PR, became enabled. The test looked very old (it used polynomial.key_switch_inner, an op which I'm not sure ever existed). The appropriate place for this test is in CKKS/Transforms, and that test already exists. As a result, I deleted this test. Should be ready to merge after CI.

@crockeea
crockeea requested a review from j2kun June 1, 2026 17:32
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Jun 2, 2026
@copybara-service
copybara-service Bot merged commit 9d05fd9 into google:main Jun 3, 2026
19 checks passed
@crockeea
crockeea deleted the fix_2157 branch June 4, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lower ckks.relinearize to polynomial dialect

2 participants