Use Double and Long hashCode functions#3046
Open
lllincoln wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks! The "check-android-compatibility" CI workflow currently fails because those methods were only added in Android API level 24 ( Lines 526 to 528 in c9f3fd5 @eamonnmcmanus, would it make sense to raise the minimum API level to 24? There are a few other TODOs in the code which could be addressed then as well (in subsequent PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
JsonPrimitive.hashCodecurrently contains a comment and the hashCode bitwise computation itself. This can be simplified using the hashCode functions that JDK 1.8+ provides through Long and Double. This PR aims to improve the readability of the function by using those Long and Double hashCode functions.Description
Java 1.8 introduced Double.hashCode and Long.hashCode.
Double.hashCode:Long.hashCode:Currently, GSON performs the same operations by essentially inlining these functions. By using the JDK provided hashCode functions and not inlining them, this PR improves the readability of the
JsonPrimitive.hashCodefunction. Thanks for considering!Checklist
This is automatically checked by
mvn verify, but can also be checked on its own usingmvn spotless:check.Style violations can be fixed using
mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.mvn clean verify javadoc:jarpasses without errors