Skip to content

Read an empty Locale string back as Locale.ROOT #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vasiliy-mikhailov wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −1
Open

Read an empty Locale string back as Locale.ROOT #3045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be96b4c
Read an empty Locale string back as Locale.ROOT
vasiliy-mikhailov Jun 26, 2026
f9afb96
Use an explicit Locale.ROOT guard and add a serialization test
vasiliy-mikhailov Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gson/src/main/java/com/google/gson/internal/bind/TypeAdapters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,10 @@ public Locale read(JsonReader in) throws IOException {
if (tokenizer.hasMoreElements()) {
variant = tokenizer.nextToken();
}
if (country == null && variant == null) {
if (language == null) {
return Locale.ROOT;
}
if (country == null) {
return new Locale(language);
} else if (variant == null) {
return new Locale(language, country);
Expand Down
14 changes: 14 additions & 0 deletions gson/src/test/java/com/google/gson/functional/DefaultTypeAdaptersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,20 @@ public void testLocaleDeserializationWithLanguage() {
assertThat(locale.getLanguage()).isEqualTo("en");
}

@Test
public void testLocaleDeserializationRoot() {
// Gson serializes Locale.ROOT to "", so it must read "" back to Locale.ROOT.

@Marcono1234 Marcono1234 Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness it would probably be good to have also a serialization test which shows that Locale.ROOT is actually serialized as "\"\"".

String json = "\"\"";
Locale locale = gson.fromJson(json, Locale.class);
assertThat(locale).isEqualTo(Locale.ROOT);
}

@Test
public void testLocaleSerializationRoot() {
// Locale.ROOT round-trips: it is serialized as an empty string.
assertThat(gson.toJson(Locale.ROOT)).isEqualTo("\"\"");
}

@Test
public void testLocaleSerializationWithLanguageCountry() {
Locale target = Locale.CANADA_FRENCH;
Expand Down