Skip to content

Require JDK 17 for building & update plugins and dependencies#2918

Merged
eamonnmcmanus merged 2 commits into
google:mainfrom
Marcono1234:marcono1234/java-17-build
Oct 6, 2025
Merged

Require JDK 17 for building & update plugins and dependencies#2918
eamonnmcmanus merged 2 commits into
google:mainfrom
Marcono1234:marcono1234/java-17-build

Conversation

@Marcono1234

Copy link
Copy Markdown
Contributor

Purpose

Require JDK 17 for building, and applies some of the version updates of #2914

Description

Applies the version updates of #2914 which require JDK 17 or newer. I have omitted the other version updates to keep this cleaner; they can be applies independently afterwards.

The CI build still runs on JDK 11 as well (but with a custom configuration) to ensure that Gson works on a version without Record classes properly as well.

Checklist

  • New code follows the Google Java Style Guide
    This is automatically checked by mvn verify, but can also be checked on its own using mvn spotless:check.
    Style violations can be fixed using mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.
  • If necessary, new public API validates arguments, for example rejects null
  • New public API has Javadoc
    • Javadoc uses @since $next-version$
      ($next-version$ is a special placeholder which is automatically replaced during release)
  • If necessary, new unit tests have been added
    • Assertions in unit tests use Truth, see existing tests
    • No JUnit 3 features are used (such as extending class TestCase)
    • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
  • mvn clean verify javadoc:jar passes without errors

The plugins and dependencies updated by this commit are related to the
requirement of using JDK 17.

@eamonnmcmanus eamonnmcmanus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's very helpful.

@eamonnmcmanus
eamonnmcmanus merged commit 32d5fea into google:main Oct 6, 2025
13 checks passed
@Marcono1234
Marcono1234 deleted the marcono1234/java-17-build branch October 6, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants