Add common layout components for PDF#3782
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3782 +/- ##
============================================
+ Coverage 66.31% 66.60% +0.28%
- Complexity 1660 1684 +24
============================================
Files 387 392 +5
Lines 10059 10145 +86
Branches 1290 1295 +5
============================================
+ Hits 6671 6757 +86
Misses 2711 2711
Partials 677 677
🚀 New features to boost your workflow:
|
Member
There was a problem hiding this comment.
Regarding the package structure, right now PageHeaderLayout, TableLayout, etc live in components package. Since components usually implies actual UI rendering code (like @Composable functions), and these classes are purely math models, would it make more sense to move these classes one level up (or maybe org.groundplatform.feature.pdf.render.layout or model)?
Collaborator
Author
|
@shobhitagarwal1612 thanks for the review 🙏 I have applied the suggestions, including renaming the layout components package, it is now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3715
(Split from #3774)
This PR focuses on adding the building blocks for the PDF document:
PageHeaderLayout(to display the survey name, job and date+time at the top),PageFooterLayout(to display the data collector information and the page number at the bottom),QrBlockLayout(to display the QR code embedding the geometry),TableLayout(with all the submission data) and their unit tests.It also adds the following helpers:
PdfConfigfor dimensions and marginsPdfGeometryfor utilities and classes which handle calculations and measurements@shobhitagarwal1612 PTAL?