Skip to content

Update QrCodeGenerator for PDF use#3781

Merged
andreia-ferreira merged 4 commits into
masterfrom
andreia/3739/qr-code-update
Jun 11, 2026
Merged

Update QrCodeGenerator for PDF use#3781
andreia-ferreira merged 4 commits into
masterfrom
andreia/3739/qr-code-update

Conversation

@andreia-ferreira

Copy link
Copy Markdown
Collaborator

Towards #3715

(Split from #3774)
This PR expands the QrCodeGenerator in order to provide a bitmap with a centered logo. This will be used to embed a QR code in PDF exports.

The shared constants were also moved from GroundQrCode to QrCodeGenerator and unit tests were added.

@shobhitagarwal1612 PTAL?

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.30%. Comparing base (b8ccfab) to head (7ab9f59).

Files with missing lines Patch % Lines
...roundplatform/ui/components/qrcode/GroundQrCode.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3781      +/-   ##
============================================
+ Coverage     66.14%   66.30%   +0.16%     
+ Complexity     1660     1659       -1     
============================================
  Files           386      387       +1     
  Lines         10039    10059      +20     
  Branches       1288     1290       +2     
============================================
+ Hits           6640     6670      +30     
+ Misses         2722     2712      -10     
  Partials        677      677              
Files with missing lines Coverage Δ
...rm/ui/components/qrcode/QrCodeGenerator.android.kt 100.00% <ø> (+100.00%) ⬆️
...ndplatform/ui/components/qrcode/QrCodeGenerator.kt 100.00% <100.00%> (ø)
...roundplatform/ui/components/qrcode/GroundQrCode.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shobhitagarwal1612 shobhitagarwal1612 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Especially the test coverage!

@andreia-ferreira andreia-ferreira merged commit b825349 into master Jun 11, 2026
19 checks passed
@andreia-ferreira andreia-ferreira deleted the andreia/3739/qr-code-update branch June 11, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants