Refactor show sign out confirmation dialogs#3583
Merged
shobhitagarwal1612 merged 11 commits intoFeb 27, 2026
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
shobhitagarwal1612
had a problem deploying
to
e2e-approval
GitHub Actions
Failure
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3583 +/- ##
============================================
+ Coverage 71.09% 71.11% +0.01%
- Complexity 1625 1629 +4
============================================
Files 337 338 +1
Lines 9096 9114 +18
Branches 1001 1003 +2
============================================
+ Hits 6467 6481 +14
- Misses 2030 2031 +1
- Partials 599 602 +3
🚀 New features to boost your workflow:
|
…outDialogState` to `AccountDialogState`.
shobhitagarwal1612
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
…nFragment.kt Co-authored-by: Andreia Ferreira <51242456+andreia-ferreira@users.noreply.github.com>
…onDialogs' into refactor-showSignOutConfirmationDialogs # Conflicts: # app/src/main/java/org/groundplatform/android/ui/home/HomeScreenFragment.kt
shobhitagarwal1612
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
andreia-ferreira
approved these changes
Feb 27, 2026
shobhitagarwal1612
deleted the
refactor-showSignOutConfirmationDialogs
branch
hassan-nsubuga
pushed a commit
to hassan-nsubuga/ground-android
that referenced
this pull request
Mar 2, 2026
hassan-nsubuga
added a commit
that referenced
this pull request
Mar 2, 2026
* Add a conditional to e2e test The CompleteAllTaskTypesTest didn't cover conditional logic. Added a conditional question to the test survey and added tests for it in order to prevent regressions Closes #3481 * Reformat code * Refactor to remove conditional test logic * Refactor to seperate responsibility, move conditional test logic to DataCollectionRobot and add a reusable method to AndroidTestDriver * Bump com.google.firebase:firebase-bom from 34.9.0 to 34.10.0 (#3582) Bumps com.google.firebase:firebase-bom from 34.9.0 to 34.10.0. --- updated-dependencies: - dependency-name: com.google.firebase:firebase-bom dependency-version: 34.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Refactor settings screen to compose (#3574) * Migrate SettingsActivity to compose * Migrate SettingsFragment.kt to compose * Update unit tests * Remove unused strings * Decouple data layer from SettingsViewModel * Exclude Compose previews from Jacoco reports (#3584) * Refactor show sign out confirmation dialogs (#3583) * Bump org.mockito:mockito-bom from 5.21.0 to 5.22.0 (#3586) Bumps [org.mockito:mockito-bom](https://github.com/mockito/mockito) from 5.21.0 to 5.22.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v5.21.0...v5.22.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-bom dependency-version: 5.22.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Rename variable to have a more conventional name * Create MultipleChoiceType sealed class to represent the kind of multiple choice questions being handled, Refactor DataCollectionRobot to use the new sealed class * Refactor to rename test constants to more descriptive names to give context about the tests * Reformat code to pass a code format check * Refactor to make constant names descriptive --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Nsubuga <nsubugahassan@gmail.com> Co-authored-by: Andreia Ferreira <51242456+andreia-ferreira@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shobhit Agarwal <ashobhit@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3438
This PR resolves, "
HomeScreenFragment.showSignOutConfirmationDialogscreates new mutable states and composables on every click, bypassing recomposition entirely."Verified the changes by opening the user details dialog and adding test coverage.
Screen_recording_20260227_120145.webm
@andreia-ferreira PTAL?