Updated HVAC general type FAN_SS_VSC_ZSPM_ZTM and opt uses for telemetry fields DFSS and DFVSC - #1740
Merged
Conversation
…try fields DFVSC and DFSS
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
shambersafai
requested changes
Sep 16, 2026
| - failed_zone_air_temperature_alarm | ||
| - high_zone_air_temperature_alarm | ||
| - low_zone_air_temperature_alarm | ||
| - schedule_run_command |
Member
There was a problem hiding this comment.
I am not sure that it makes the most sense to add this one here. What is the full canonical type of your device? It might make more sense to add this to one of the other abstracts on it.
|
|
||
| FAN_SS_VSC_ZSPM_ZTM: | ||
| guid: "d02f772c-7c0a-4221-9ccd-02756c65b158" | ||
| description: "Fan with start/stop status, open-loop speed control, zone static pressure monitorinig, and zone temperature monitoring." |
shambersafai
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added failed_zone_air_static_pressure_alarm to the telemetry fields folder. New general type FAN_SS_VSC_ZSPM_ZTM. Added failed_zone_air_static_pressure_alarm to ZSPM, local_override_alarm to DFVSC, schedule_run_command to DFSS as opt_uses.