Skip to content

Handle RuntimeExceptions in DaggerSuperficialValidation getMessage / trace generation #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 11, 2026
Merged

Handle RuntimeExceptions in DaggerSuperficialValidation getMessage / trace generation #5185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion dagger-compiler/main/java/dagger/internal/codegen/base/DaggerSuperficialValidation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@
import dagger.internal.codegen.xprocessing.XExecutableTypes;
import dagger.internal.codegen.xprocessing.XTypeNames;
import dagger.internal.codegen.xprocessing.XTypes;
import java.io.PrintWriter;
import java.io.StringWriter;
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashSet;
Expand Down Expand Up @@ -646,7 +648,23 @@ private ValidationException append(XAnnotationValue value) {

@Override
public String getMessage() {
return String.format("\n Validation trace:\n => %s", getTrace());
try {
return String.format("\n Validation trace:\n => %s", getTrace());
} catch (RuntimeException e) {
// TODO(b/522448305): Remove this workaround once the underlying KSP bug is fixed.
// Note: This block (if executed) will be loaded from a different class loader, and
// therefore Guava dependency is avoided in the implementation.
StringWriter stringWriter = new StringWriter();
try (PrintWriter printWriter = new PrintWriter(stringWriter)) {
e.printStackTrace(printWriter);
}
return String.format(
"\n Validation trace (incomplete due to %s):\n\n"
+ "// Stack trace in message (start)\n"
+ "%s"
+ "// Stack trace in message (end)\n",
e.getClass().getSimpleName(), stringWriter.toString());
}
}

public String getTrace() {
Expand Down
Loading