Run an autofix pass on github workflows using zizmor#2233
Open
dmah42 wants to merge 1 commit into
Open
Conversation
Zizmor is going to be automatically installed in this repo shortly. To avoid any churn, this is a pre-run to fix up any potential vulnerabilities identified by the tool.
LebedevRI
reviewed
Jun 25, 2026
| - name: configure cmake | ||
| run: > | ||
| cmake -S . -B ${{ runner.workspace }}/_build/ | ||
| cmake -S . -B $env:RUNNER_WORKSPACE/_build/ |
Collaborator
There was a problem hiding this comment.
This is literally the first time i'm seeing this syntax.
Collaborator
There was a problem hiding this comment.
I don't suppose there is a way to make this be ${RUNNER_WORKSPACE}?
Member
Author
There was a problem hiding this comment.
apparently this is exactly the risk. the way the action works is that it does a literal text replacement, opening the door to potential malicious commands (i think it's unlikely but hey).
Member
Author
There was a problem hiding this comment.
oh and this is using the powershell syntax, basically. if it was linux it would be $RUNNER_WORKSPACE
LebedevRI
reviewed
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zizmor is going to be automatically installed in this repo shortly. To avoid any churn, this is a pre-run to fix up any potential vulnerabilities identified by the tool.