refactor(firestore) : comprehensive refactoring for FirestoreSessionService#5663
Open
Dumeng wants to merge 6 commits into
Open
refactor(firestore) : comprehensive refactoring for FirestoreSessionService#5663Dumeng wants to merge 6 commits into
Dumeng wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
N/A
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
This Pull Request introduces comprehensive refactoring, performance optimizations, and robustness improvements to the
FirestoreSessionService. It simplifies the core implementation, aligns state handling logic with other session services, fixes side-effects in transactions, and significantly improves read performance for bulk operations.Solution:
Optimized Batch Retrieval: Updated
list_sessionsto leverage Firestore's nativeclient.get_all(...)method. This fetches multiple user state documents in a single optimized RPC request rather than individual sequential reads, significantly reducing read latency and overhead.Aligned State Handling: Refactored state management logic to match the established, robust patterns found in DatabaseSessionService.
Transaction Safety: Removed unsafe side-effects inside transaction callbacks within
append_eventto ensure idempotency and reliability during automatic Firestore transaction retries.Revision Tracking: Explicitly initialized session revision tracking to 0 upon session creation to guarantee monotonic tracking consistency.
Simplified Implementation: Streamlined internal data extraction and simplified redundant record lookups for improved long-term maintainability.
Import Standards: Resorted and updated import statements to strictly adhere to the ADK project's relative import conventions and code style guide.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.