Skip to content

refactor(firestore) : comprehensive refactoring for FirestoreSessionService#5663

Open
Dumeng wants to merge 6 commits into
google:mainfrom
Dumeng:firestore
Open

refactor(firestore) : comprehensive refactoring for FirestoreSessionService#5663
Dumeng wants to merge 6 commits into
google:mainfrom
Dumeng:firestore

Conversation

@Dumeng
Copy link
Copy Markdown

@Dumeng Dumeng commented May 11, 2026

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

N/A

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
This Pull Request introduces comprehensive refactoring, performance optimizations, and robustness improvements to the FirestoreSessionService. It simplifies the core implementation, aligns state handling logic with other session services, fixes side-effects in transactions, and significantly improves read performance for bulk operations.

Solution:

  • Optimized Batch Retrieval: Updated list_sessions to leverage Firestore's native client.get_all(...) method. This fetches multiple user state documents in a single optimized RPC request rather than individual sequential reads, significantly reducing read latency and overhead.

  • Aligned State Handling: Refactored state management logic to match the established, robust patterns found in DatabaseSessionService.
    Transaction Safety: Removed unsafe side-effects inside transaction callbacks within append_event to ensure idempotency and reliability during automatic Firestore transaction retries.

  • Revision Tracking: Explicitly initialized session revision tracking to 0 upon session creation to guarantee monotonic tracking consistency.

  • Simplified Implementation: Streamlined internal data extraction and simplified redundant record lookups for improved long-term maintainability.

  • Import Standards: Resorted and updated import statements to strictly adhere to the ADK project's relative import conventions and code style guide.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@Dumeng Dumeng changed the title Firestore refactor(firestore) : comprehensive refactoring for FirestoreSessionService May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant