deploy.sh & README improvements (based on pr 106)#107
Open
akushnarov wants to merge 17 commits into
Open
Conversation
… setup steps in non-interactive mode
|
Readability review is not required. |
![gps-readability-bot[bot]](https://avatars.githubusercontent.com/u/106399418?s=60&v=4){kind=small}
akushnarov
changed the title
akushnarov
requested review from
christophervoelpel
and removed request for
adamread
christophervoelpel
approved these changes
Jun 10, 2026
christophervoelpel
left a comment
christophervoelpel
left a comment
Contributor
There was a problem hiding this comment.
LGTM - one suggestion to add back a sentence for clarity
| echo " buckets' → select ${GCS_BUCKET} → confirm. Registers your" | ||
| echo " project bucket so deploy-ui.sh can target it." | ||
| echo " (a) Click 'Get started' and complete the wizard." | ||
| echo " (b) On the same page, click the bucket dropdown → '+ Add bucket'" |
Contributor
There was a problem hiding this comment.
add this back for clarity - cost me 10 minutes on the first deploy
"AFTER (a) finishes (the bucket dropdown only appears once a bucket exists), "
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.