feat(deploy): unify backend and UI deployment under deploy.sh - updated README by christophervoelpel · Pull Request #106 · google-marketing-solutions/scene-machine

christophervoelpel · 2026-06-05T22:11:24Z

Refactored argument parsing and added targeted deployment flags ( --backend-only , --ui-only ).
Optimized API enablement with an API cache comparison to speed up subsequent runs.
Made pre-flight tool requirements component-aware so they only check for what is actually needed.
Deprecated deploy-ui.sh and redirected all UI flows through the unified deploy.sh .
Added startup pre-flight checks to ensure the Firebase CLI session is actively authenticated.
Optimized GCS/Firebase linkage checks to avoid timeouts on accounts with 1,500+ active projects.
Restored direct Firestore API curl loops for database configurations upload.
Added environment override capability for CLOUD_RUN_URL .
Enforced OAuth Consent Screen setup via a blocking 15-second polling loop.
Enforced App Engine IAP configuration via a blocking 15-second polling loop.

…kage

…ssing script

…ng loops

…nal banner

gps-readability-bot · 2026-06-05T22:11:31Z

Readability review is not required.

…ompletion

akushnarov · 2026-06-08T14:58:25Z

-echo
-echo "════════════════════════════════════════════════════════════════════════"
-echo
+echo "WARNING: deploy-ui.sh is deprecated. Redirecting to './deploy.sh --ui-only'..."


Let's remove deploy-ui.sh, no need to support it in the future

+1. This seems more confusing than helpful to new users.

akushnarov · 2026-06-08T15:09:08Z

-echo "       the setup dialog. User Type is set under 'Audience' — pick"
-echo "       'Internal' if you have a Workspace org; otherwise 'External' and"
-echo "       add yourself as a test user."
+echo "       the setup dialog. Set User Type to 'Internal' for @google.com logins."


Why @google.com?
Proposed: "In the OAuth setup dialog, set User Type to 'Internal' if you only want users within your own Google Workspace organization to access the app (recommended for testing), or 'External' if you want anyone to be able to log in."

I'd just say that internal is recommended for security purposes when possible.

akushnarov · 2026-06-08T15:12:05Z

+* **Deploy UI Only**: `./deploy.sh --ui-only`
+* **Local Development Build**: `./deploy.sh --ui-only --local` (or `./deploy.sh --ui-only local`) to build the Angular application files locally without triggering an App Engine deployment.
+
+To run the script in a non-interactive/headless environment (such as an AI agent like Jetski or Claude), use the `-y` / `--yes` / `--non-interactive` flag to auto-confirm target configuration prompts:


a bit confusing to have too many flags with the same functionality, I would keep only standard -y & --yes

as above, I would go with --non-interactive, as it's the most clear.

akushnarov · 2026-06-08T15:14:37Z

+      AUTO_CONFIRM=true
+      shift
+      ;;
+    --backend-only|--be-only)


let's leave only one --be-only

+1. I'd say --backend-only is better, as it's more descriptive and clear.

akushnarov · 2026-06-08T15:15:42Z

+TARGETED=false
+DEPLOY_MODE=""
+
+while [[ $# -gt 0 ]]; do


Let's have flags -h & --help for help (to output all the available options)?

adamread

I have some comments on the flags and some minor concerns about the polling during a non-interactive deployment.

adamread · 2026-06-09T08:06:58Z

-echo
-echo "════════════════════════════════════════════════════════════════════════"
-echo
+echo "WARNING: deploy-ui.sh is deprecated. Redirecting to './deploy.sh --ui-only'..."


+1. This seems more confusing than helpful to new users.

adamread · 2026-06-09T08:27:39Z

+      AUTO_CONFIRM=true
+      shift
+      ;;
+    --backend-only|--be-only)


+1. I'd say --backend-only is better, as it's more descriptive and clear.

adamread · 2026-06-09T08:29:08Z

Google tools generally use lower_snake_case for flags. Should we do this for consistency?

adamread · 2026-06-09T08:30:38Z

+
+while [[ $# -gt 0 ]]; do
+  case "$1" in
+    -y|--yes|--non-interactive)


I think just having --non_interactive would suffice, as it's more descriptive and clear.

adamread · 2026-06-09T08:42:43Z

+      TARGETED=true
+      shift
+      ;;
+    local|--local)


I would stick to just the flag version (i.e. --local) for consistency.

adamread · 2026-06-10T08:50:49Z

+  echo "Enabling Firebase Management API..."
  gcloud services enable firebase.googleapis.com --project=$PROJECT
+  # Refresh cache
+  ENABLED_APIS=$(gcloud services list --enabled --project="$PROJECT" --format="value(config.name)" 2>/dev/null || true)


adamread · 2026-06-10T08:52:00Z

-echo "       the setup dialog. User Type is set under 'Audience' — pick"
-echo "       'Internal' if you have a Workspace org; otherwise 'External' and"
-echo "       add yourself as a test user."
+echo "       the setup dialog. Set User Type to 'Internal' for @google.com logins."


I'd just say that internal is recommended for security purposes when possible.

adamread · 2026-06-10T08:53:26Z

+  else
+    echo "Enabling Identity Toolkit API (needed for Auth config)..."
+    gcloud services enable identitytoolkit.googleapis.com --project=$PROJECT
+    ENABLED_APIS=$(gcloud services list --enabled --project="$PROJECT" --format="value(config.name)" 2>/dev/null || true)


also not required. It's not used again in the script.

adamread · 2026-06-10T09:13:12Z

+  echo "[>] Checking if bucket ${GCS_BUCKET} is linked to Firebase Storage..."
+  BUCKET_WAIT_ATTEMPTS=0
+  BUCKET_WAIT_MAX=120   # 120 × 15s = 30 min total
+  while true; do


I'm not sure about this (and the polling further down) from the automated deployment perspective. If this isn't being run in an interactive session, someone may eventually see this in the logs after the deployment fails.

I think fast fail when AUTO_CONFIRM is true might be a good idea. That way we don't block CI pipelines for 30 min if someone messed up the initial deployment.

We should also add a note in the readme that an automated deployment cannot be done for the first time.

adamread · 2026-06-10T09:15:11Z

+* **Deploy UI Only**: `./deploy.sh --ui-only`
+* **Local Development Build**: `./deploy.sh --ui-only --local` (or `./deploy.sh --ui-only local`) to build the Angular application files locally without triggering an App Engine deployment.
+
+To run the script in a non-interactive/headless environment (such as an AI agent like Jetski or Claude), use the `-y` / `--yes` / `--non-interactive` flag to auto-confirm target configuration prompts:


as above, I would go with --non-interactive, as it's the most clear.

… setup steps in non-interactive mode

christophervoelpel added 12 commits June 6, 2026 00:06

refactor(deploy): implement unified argument parsing and targeting flags

a6d8998

perf(deploy): optimize service enablement via API cache check

e196b1e

fix(deploy): make pre-flight tool requirements component-aware

41755a0

refactor(deploy): deprecate deploy-ui.sh and redirect to deploy.sh

fc030bb

docs(deploy): document unified deployment interface and flags

6577db7

fix(deploy): add firebase login check to pre-flight requirements

bc6dfe3

fix(deploy): decouple Firebase API enablement from project linkage check

36db864

fix(deploy): use lightweight apps list check for Firebase project lin…

dafdfd9

…kage

fix(deploy): restore inline firestore config curl calls instead of mi…

10b2449

…ssing script

fix(deploy): allow CLOUD_RUN_URL override from environment

ce1baab

fix(deploy): enforce OAuth consent and IAP setup via background polli…

75a5b81

…ng loops

docs(deploy): label user access grant as a required manual step in fi…

4eeea8b

…nal banner

gps-readability-bot Bot approved these changes Jun 5, 2026

View reviewed changes

docs(deploy): remove deployment plan from PR

1a6b1f9

gps-readability-bot Bot approved these changes Jun 5, 2026

View reviewed changes

christophervoelpel added 2 commits June 6, 2026 00:18

style(deploy): sort REQUIRED_APIS list alphabetically

31b1d66

docs(deploy): print explicit manual console instructions at backend c…

f091619

…ompletion

gps-readability-bot Bot approved these changes Jun 5, 2026

View reviewed changes

christophervoelpel requested review from adamread and akushnarov June 8, 2026 11:13

gps-readability-bot Bot approved these changes Jun 8, 2026

View reviewed changes

akushnarov requested changes Jun 8, 2026

View reviewed changes

gps-readability-bot Bot approved these changes Jun 8, 2026

View reviewed changes

adamread reviewed Jun 10, 2026

View reviewed changes

gps-readability-bot Bot approved these changes Jun 10, 2026

View reviewed changes

akushnarov added 2 commits June 10, 2026 13:38

Adjusted deployment flags, texts

40b3184

refactor: move helper functions to library, enforce failure on manual…

87ca4c3

… setup steps in non-interactive mode

gps-readability-bot Bot approved these changes Jun 10, 2026

View reviewed changes

Conversation

christophervoelpel commented Jun 5, 2026

Uh oh!

gps-readability-bot Bot commented Jun 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamread left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants