Skip to content

fix(configuration): restore yaml v2 parsing#12

Merged
wy65701436 merged 1 commit into
goharbor:release/2.8from
chlins:chore/downgrade-go-yaml
Jun 2, 2026
Merged

fix(configuration): restore yaml v2 parsing#12
wy65701436 merged 1 commit into
goharbor:release/2.8from
chlins:chore/downgrade-go-yaml

Conversation

@chlins

@chlins chlins commented Jun 2, 2026

Copy link
Copy Markdown
Member

This pull request updates the YAML parsing library used in the project from gopkg.in/yaml.v3 to gopkg.in/yaml.v2 in the main code and tests, and adjusts dependency declarations accordingly. The change ensures that the codebase consistently uses version 2 of the YAML library, possibly for compatibility or stability reasons.

Dependency and import updates:

  • Switched YAML import in both configuration/parser.go and configuration/configuration_test.go from gopkg.in/yaml.v3 to gopkg.in/yaml.v2. [1] [2]
  • Updated the main dependency in go.mod to require gopkg.in/yaml.v2 v2.4.0 instead of gopkg.in/yaml.v3 v3.0.1.
  • Moved gopkg.in/yaml.v3 v3.0.1 to an indirect dependency in go.mod, reflecting that it is no longer directly used by the project.

Signed-off-by: chlins <chlins.zhang@gmail.com>

@MinerYang MinerYang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@wy65701436 wy65701436 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 11540ea into goharbor:release/2.8 Jun 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants