Forms: allow scoping "Document" question attachments to specific destinations

[hmarques012]

Code of Conduct

• I agree to follow this project's Code of Conduct

Contribution description

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

Feature description

Current behavior

When a form has multiple Destinations (e.g. it generates a Ticket for Team A and
another Ticket for Team B from the same submission), the answer to a "Document"
type question (an uploaded file) is automatically linked to all destinations
generated by that submission — regardless of whether each destination's
"Item to create" > custom content actually references that question via the
#Question / #Answer tags.

The per-destination "Custom fields" configuration (autoconfig or manual # tags)
only controls the ticket's textual content. It has no effect on which uploaded
documents get attached to which destination — every Document-type answer is
linked to every destination item.

Desired behavior

Provide a way to scope a "Document" type question's attachment to only the
destination(s) where it is relevant, for example:

• A per-destination toggle/checkbox for each Document-type question, to
  include or exclude that specific attachment, or
• Only auto-attach the document to a destination when that destination's
  custom content actually references the corresponding question (mirroring
  how the text tags already work)

Example use case

A single HR form reports a role/position change for an employee. It has one
"Document" question (e.g. a scanned ID/driver's license) and creates two
items via two Destinations:

• Destination A (fleet/vehicle team): needs the document — correct, expected.
• Destination B (general service desk): does not need the document, but
  receives it anyway, because the file is currently attached to every
  destination regardless of its custom content configuration.

Today the only workaround is manually deleting the Document_Item link from
Destination B's resulting ticket after each submission, which does not scale
well (there is no reliable way to automate the cleanup, since the uploaded
file's name is user-controlled and unpredictable).

GLPI version

11.0.8

Additional context

Possibly related: #24159 ("All form fields are displayed when creating a
ticket") shows there are already known gaps in how per-destination content
scoping behaves in the native Forms module — this request is about extending
that same scoping concept to file/document attachments, not just text.

[marifex]

Root cause looks like two spots. EndUserInputNameProvider::getFiles() flattens every uploaded file into one submission-wide filename/prefix/tag set and drops the originating question id, and then AbstractCommonITILFormDestination calls setFilesInput() unconditionally for each destination, so every Ticket/Problem/Change ends up with the whole set regardless of its content config.

Scoping by the content tags alone probably isn't enough, since a document can be required without its value showing in the content, and keying attachment off the content would change how existing forms behave. A per-destination Documents field (attach all / attach selected questions / attach none) would match the existing destination field pattern and could default to attach all so current forms are unaffected. To keep it contained, the question id could ride along as an extra array next to filename/prefix/tag rather than reshaping the submitted-files structure.

I don't see a Documents field or an open PR for this yet. Is it already planned or being worked on your side, and would a PR along these lines be welcome before I start?

[hmarques012]

Thanks for digging into the root cause, @marifex — that matches what I was seeing.
I'm not aware of any existing PR or planned work on this (checked before opening the issue). The "attach selected questions" mode you're proposing would fully solve the real-world case that prompted this report: a form with one File question shared across two destinations, where only one of them actually needs the attached document. A PR along these lines would be very welcome from my side.