Add full cvmfsexec support in GWMS#631
Open
namrathaurs wants to merge 2 commits into
Open
Conversation
3 tasks
namrathaurs
force-pushed
the
v311_revised_latest_dupe
branch
from
2e467fd to
72ca253
Compare
namrathaurs
force-pushed
the
v311_revised_latest_dupe
branch
from
fcd02f3 to
f385016
Compare
namrathaurs
force-pushed
the
v311_revised_latest_dupe
branch
from
f385016 to
f51f263
Compare
shreyb
reviewed
Mar 11, 2026
| # download the cvmfsexec repository contents as a compressed tarball and extract its contents | ||
| # before extracting contents, make sure the `latest` directory for cvmfsexec exists | ||
| ensure_directory_exists "$cvmfsexec_latest" | ||
| curl -sL https://github.com/cvmfs/cvmfsexec/archive/master.tar.gz | tar -xz -C "$cvmfsexec_latest" --strip-components=1 |
There was a problem hiding this comment.
Similar to how line 78 had a reference to $CVMFSEXEC_REPO, it might make this more readable to set a global variable to this URL, and then reference the variable here.
Contributor
Author
There was a problem hiding this comment.
Point taken, thanks for the suggestion @shreyb!
shreyb
reviewed
Mar 11, 2026
shreyb
left a comment
shreyb
left a comment
There was a problem hiding this comment.
This mostly looks good to me. I had just one comment.
Contributor
Author
|
Hi Shreyas,
Somehow I could not see this comment of yours on Github, so replying here:
In Bash, the ,, is used to convert the value to lowercase. This helps resolve all unintentional specification of values of `glidein_cvmfs_require` (e.g. Required, REQUIRED, etc.) to required.
Possible values of `GLIDEIN_CVMFS_REQUIRE` (which is a factory config knob) include REQUIRED, PREFERRED, and NEVER.
Hope that helps,
Namratha
________________________________
From: Shreyas Bhat ***@***.***>
Sent: Wednesday, March 11, 2026 9:19 AM
To: glideinWMS/glideinwms ***@***.***>
Cc: Urs, NAMRATHA ***@***.***>; Author ***@***.***>
Subject: [EXT] Re: [glideinWMS/glideinwms] Add full cvmfsexec support in GWMS (PR #631)
@shreyb commented on this pull request.
________________________________
In creation/web_base/glidein_startup_ff.sh<#631 (comment)>:
mount_cvmfs_repos $gwms_cvmfsexec_mode $cvmfs_config_repo $cvmfs_add_repos
+ if [[ $? -ne 0 ]]; then
+ glidein_cvmfs_require=$(gconfig_get GLIDEIN_CVMFS_REQUIRE "$glidein_config")
+ glidein_cvmfs_require=${glidein_cvmfs_require,,}
What does the ,, do with the parameter?
—
Reply to this email directly, view it on GitHub<#631 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADY4LAS3ILDONQFPD5F6LOL4QFYW7AVCNFSM6AAAAACP3WHPGOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSMRZHE2TGNJQGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #372 and contains the changes from the same.
During the implementation and testing of full cvmfsexec support (coming through this PR), a local branch by the name
branch_v3_11_revised_latestwas in use. Since there were a couple of development releases in the meantime, this PR had to be rebased withbranch_v3_11which resulted in feature-related changes to go out of sync. To avoid further confusion, a new branch was created based onbranch_v3_11_revised_latestand was namedv311_revised_latest_dupe, which is the source for this PR.