Conversation
connoraird
reviewed
Jun 23, 2026
connoraird
approved these changes
Jun 24, 2026
connoraird
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I was also experiencing the failing examples, I'm not sure what's causing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new function
glass.resample_shapes()that takes an array of ellipticity and randomises them. The function can optionally compensate for the intrinsic variancevargorvargammaof the (reduced) shear field (i.e., the variance of the ellipticities will be equal to the input array after applying a (reduced) shear).Closes: #1116
Changelog entry
Added: A new function
glass.resample_shapes()for resampling an existing catalogue of ellipticities.Checks