gh-984: Add config to run on Archer2#1064
Conversation
596542c to
cad9042
Compare
c6cd4bd to
9f3dcf3
Compare
paddyroddy
left a comment
There was a problem hiding this comment.
Small comment on the files itself, will now try on ARCHER2
paddyroddy
left a comment
There was a problem hiding this comment.
Updates after running it more
| Now we have cloned glass, we can run the script | ||
| [run_regression_test.sh](./run_regression_test.sh) which will setup the required | ||
| environments and submit regression test job to slurm. A help message is | ||
| provided. Just run `run_regression_test.sh -h` from the root of the GLASS repo. |
There was a problem hiding this comment.
> run_regression_test.sh -h
-bash: run_regression_test.sh: command not foundThere was a problem hiding this comment.
The instructions aren't clear IMO. It should say something like:
cd glass/tests/benchmarks/archer2
bash run_regression_test.shor
bash glass/tests/benchmarks/archer2/run_regression_test.shor
cd "${HOME/home/work}"/glass/tests/benchmarks/archer2
./run_regression_test.shThere was a problem hiding this comment.
Also can we give them a sample command? Like I'm genuinely not sure how to run this myself. We should make "start" and "end" really unambiguous. Also, -d | --glass-dir <glass/dir> Path to the cloned glass directory. Does that mean I should have this shell script outside the repo?
There was a problem hiding this comment.
I've made some changes which hopefully make it clearer
This reverts commit 9f36557.
| ./tests/benchmarks/archer2/run_regression_test.sh \ | ||
| -d "$(pwd)" \ | ||
| -s main \ | ||
| -e feature \ | ||
| -a myaccount |
There was a problem hiding this comment.
I got this working with ./tests/benchmarks/archer2/run_regression_test.sh -d "$(pwd)" -s main -e connor/run-on-archer2 -a ecsega23.
Maybe we should document that it's ecsega23 rather than proddy?
Also is the -d mandatory here? Is there a way we could detect that we're already in the directory?
There was a problem hiding this comment.
Maybe we should document that it's ecsega23 rather than proddy?
I've not been specific about the account as this is only for the current grant code. In the future it will likely change to a different account code.
Also is the -d mandatory here?
It is. When a job is submitted the script is saved and ran from somewhere else which makes determining paths a little more complicated. We could default to pwd but I think that's not very intuitive and would only work if running from the root of the glass dir . However, I could be convinced if you feel strongly.
There was a problem hiding this comment.
In the future it will likely change to a different account code.
I agree to not specifying the account. But we should make it clear that "account" is not your username.
There was a problem hiding this comment.
However, I could be convinced if you feel strongly.
Agreed that it may be unintuitive. Seems a little odd to me, but there is probably no other way.
There was a problem hiding this comment.
Should we document how to get the results? I'm not sure. Could look it up but we might as well document.
There was a problem hiding this comment.
Makes sense, I'll have a go
paddyroddy
left a comment
There was a problem hiding this comment.
I've been able to run this now and I think the instructions are complete
Description
Testing
maintoconnor/run-on-archer2which runs as expected.Refs: #984
Closes: #984
Checks