Skip to content

gh-984: Add config to run on Archer2#1064

Merged
connoraird merged 62 commits into
mainfrom
connor/run-on-archer2
Jun 3, 2026
Merged

gh-984: Add config to run on Archer2#1064
connoraird merged 62 commits into
mainfrom
connor/run-on-archer2

Conversation

@connoraird

@connoraird connoraird commented May 11, 2026

Copy link
Copy Markdown
Contributor

Description

  • Adds submission scripts and documentation of how to run the regression tests on Archer2.

Testing

  • I have tested the archer2 script by running a regression test with fd80e8f as the starting version and main as the final version and received an error due to the change in the glass modules which causes benchmarks for fd80e8f to fail.
  • I have also ran comparing main to connor/run-on-archer2 which runs as expected.

Refs: #984
Closes: #984

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@connoraird connoraird self-assigned this May 11, 2026
@connoraird
connoraird force-pushed the connor/run-on-archer2 branch from 596542c to cad9042 Compare May 11, 2026 16:29
@connoraird
connoraird force-pushed the connor/run-on-archer2 branch from c6cd4bd to 9f3dcf3 Compare May 12, 2026 13:53
@connoraird
connoraird marked this pull request as ready for review May 19, 2026 09:19

@paddyroddy paddyroddy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on the files itself, will now try on ARCHER2

Comment thread tests/benchmarks/archer2/submission_script_cpu.sh Outdated
Comment thread tests/benchmarks/archer2/submission_script_cpu.sh Outdated
Comment thread tests/benchmarks/archer2/README.md Outdated
Comment thread tests/benchmarks/archer2/README.md Outdated
Comment thread tests/benchmarks/archer2/README.md
@connoraird
connoraird requested a review from paddyroddy June 2, 2026 13:34
Comment thread tests/benchmarks/archer2/README.md Outdated

@paddyroddy paddyroddy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates after running it more

Comment thread tests/benchmarks/archer2/README.md Outdated
Comment thread tests/benchmarks/archer2/README.md Outdated
Comment on lines +49 to +52
Now we have cloned glass, we can run the script
[run_regression_test.sh](./run_regression_test.sh) which will setup the required
environments and submit regression test job to slurm. A help message is
provided. Just run `run_regression_test.sh -h` from the root of the GLASS repo.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> run_regression_test.sh -h
-bash: run_regression_test.sh: command not found

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions aren't clear IMO. It should say something like:

cd glass/tests/benchmarks/archer2
bash run_regression_test.sh

or

bash glass/tests/benchmarks/archer2/run_regression_test.sh

or

cd "${HOME/home/work}"/glass/tests/benchmarks/archer2
./run_regression_test.sh

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we give them a sample command? Like I'm genuinely not sure how to run this myself. We should make "start" and "end" really unambiguous. Also, -d | --glass-dir <glass/dir> Path to the cloned glass directory. Does that mean I should have this shell script outside the repo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some changes which hopefully make it clearer

@connoraird
connoraird requested a review from paddyroddy June 2, 2026 16:48
Comment thread tests/benchmarks/archer2/README.md Outdated
Comment on lines +61 to +65
./tests/benchmarks/archer2/run_regression_test.sh \
-d "$(pwd)" \
-s main \
-e feature \
-a myaccount

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this working with ./tests/benchmarks/archer2/run_regression_test.sh -d "$(pwd)" -s main -e connor/run-on-archer2 -a ecsega23.

Maybe we should document that it's ecsega23 rather than proddy?

Also is the -d mandatory here? Is there a way we could detect that we're already in the directory?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should document that it's ecsega23 rather than proddy?

I've not been specific about the account as this is only for the current grant code. In the future it will likely change to a different account code.

Also is the -d mandatory here?

It is. When a job is submitted the script is saved and ran from somewhere else which makes determining paths a little more complicated. We could default to pwd but I think that's not very intuitive and would only work if running from the root of the glass dir . However, I could be convinced if you feel strongly.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future it will likely change to a different account code.

I agree to not specifying the account. But we should make it clear that "account" is not your username.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I could be convinced if you feel strongly.

Agreed that it may be unintuitive. Seems a little odd to me, but there is probably no other way.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document how to get the results? I'm not sure. Could look it up but we might as well document.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'll have a go

@connoraird
connoraird requested a review from paddyroddy June 3, 2026 10:07

@paddyroddy paddyroddy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been able to run this now and I think the instructions are complete

@connoraird
connoraird merged commit 3dfe047 into main Jun 3, 2026
17 of 19 checks passed
@connoraird
connoraird deleted the connor/run-on-archer2 branch June 3, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

array-api Work is related to the Array API benchmarks Benchmarking work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run old regression tests on myriad/ARCHER2

2 participants