Conversation
Co-authored-by: Codex <noreply@openai.com>
|
|
||
| Deploy an extension version containing the `OnaInstanceUrl` policy schema before applying this policy. The Chrome Web Store extension ID is `dodmmooeoklaejobgleioelladacbeki`; confirm the installed ID at `chrome://extensions`. Unpacked builds can have a different ID. | ||
|
|
||
| `OnaInstanceUrl` is an optional string containing an absolute HTTP(S) origin, for example `https://ona.example.com` or `https://ona.example.com:8443/`. HTTPS is recommended. A trailing slash is normalized away. Credentials, non-root paths, query strings, fragments, whitespace, missing schemes, and other protocols are invalid. This policy does not test server reachability or authentication. |
Member
There was a problem hiding this comment.
HTTPS is recommended
I believe HTTPS is enforced on our end. Could be wrong though
| 4. Change the policy URL and reload policies while leaving the popup or SCM page open. The displayed URL and links should update. Visit a different Ona instance with hopping previously enabled and confirm it cannot replace the managed URL. | ||
| 5. Remove the policy and reload policies. Editing should become available and the previously saved user URL should return, or the built-in default if no URL was saved. An invalid policy value should also fall back. | ||
|
|
||
| ## Host access is separate |
Member
There was a problem hiding this comment.
this section feels a bit superfluous / irrelevant, think we should consider removing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow administrators to centrally configure the Ona URL through Chrome policy while retaining users’ preferences after policy removal. Host access still requires separate permission.
Validated with Chrome and Firefox builds, 63 tests, TypeScript, ESLint, and Prettier.