fix: add gibo --version assertion after install#63
Open
kitsuyui wants to merge 2 commits into
Open
Conversation
Explicitly calls `gibo --version` after copying and chmod-ing the binary. This verifies the installed binary is executable, ABI-compatible with the runner, and reports the expected version — making the implicit "it works" contract explicit and logged to stderr. Previously the action relied on `gibo root` (called to locate the boilerplates directory) as an indirect install verification. Calling `--version` first makes the assertion intentional and surfaced in the Actions log.
gibo (cobra-based CLI) exposes its version via the 'version' subcommand, not a '--version' flag. The previous assertion failed with 'unknown flag: --version' (exit 1), breaking the install step on every runner. Switch to 'gibo version', which prints the version and exits 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After copying the binary and setting its executable bit, the action now calls
gibo --versionand redirects the output to stderr. This makes thepost-install assertion explicit: the binary is present, executable,
ABI-compatible with the runner, and reports the expected version.
Previously the action relied on
gibo root— called immediately after tolocate the boilerplates directory — as an indirect install check. That call
verified the binary worked but was not designed as an assertion and its
purpose was not visible in the log. Calling
--versionfirst makes theintent clear and surfaces the installed version in the Actions step output.
Changes
action.yml: add"${bin_dir}/${executable}" --version >&2betweenchmod +xand thegibo rootcall.Test plan
gibo v3.0.22(or the overridden version) on stderr--versionfails the step fast before any further state is created