ci: expand test matrix to all 6 supported platforms#57
Open
kitsuyui wants to merge 1 commit into
Open
Conversation
action.yml handles 6 RUNNER_OS-RUNNER_ARCH combinations (Linux/macOS/Windows x64/ARM64), but the CI matrix only tested 3: ubuntu-latest (Linux-X64), macos-latest (macOS-ARM64), and windows-latest (Windows-X64). Add the three missing runners: ubuntu-24.04-arm - Linux ARM64 macos-13 - macOS x64 (Intel Mac) windows-11-arm - Windows ARM64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
action.ymlhandles sixRUNNER_OS-RUNNER_ARCHcombinations(Linux/macOS/Windows × x64/ARM64), but the CI matrix only tested three:
ubuntu-latestmacos-latestwindows-latestubuntu-24.04-armmacos-13windows-11-armPlatform-specific regressions (binary URL resolution, sha256sum
implementation differences, unzip behaviour, path separators) in the three
untested branches would go undetected until users reported them.
Change
Expand the
os:matrix in.github/workflows/main.ymlto include the threemissing runner labels. All six jobs run on every PR and push to
main.Impact
timeout-minutes: 10; no change to logicTest plan