fix: use bash and set -o pipefail in check-required-status-checks.sh#94
Open
kitsuyui wants to merge 1 commit into
Open
fix: use bash and set -o pipefail in check-required-status-checks.sh#94kitsuyui wants to merge 1 commit into
kitsuyui wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
set -o pipefail, a failure ingh apiat the start of the pipelineis silently swallowed by
sort -u, leavingrequired_checks_fileempty. The script then exits with a misleading "ruleset has no required_status_checks entries" error instead of surfacing the real cause (auth failure, network error, rate limit, etc.).POSIX
shdoes not supportset -o pipefail, so switch the shebang tobash— consistent withrun-with-timeout.shand the other scripts in this repo that already use#!/usr/bin/env bashwithset -euo pipefail.Changes:
scripts/check-required-status-checks.sh:#!/bin/sh→#!/usr/bin/env bash,set -eu→set -euo pipefailVerification:
shfmt -d scripts/*.sh: no diffshellcheck scripts/*.sh: no warningsactionlint -color: no warnings