Skip to content

fix: refresh draft release notes on every push to main#90

Open
kitsuyui wants to merge 1 commit into
mainfrom
fix/audit-draft-release-notes-frozen-on-first-create-001
Open

fix: refresh draft release notes on every push to main#90
kitsuyui wants to merge 1 commit into
mainfrom
fix/audit-draft-release-notes-frozen-on-first-create-001

Conversation

@kitsuyui

Copy link
Copy Markdown
Member

Summary

The draft release body for v0.2.4 has been frozen since 2026-05-12 despite multiple pushes to main. Two independent issues caused this:

Issue 1 — path filter too narrow: paths: [action.yml] meant only commits that touched action.yml triggered a draft refresh. Changes to scripts, workflows, or docs (e.g. PR #56#74) were silently excluded.

Issue 2 — softprops preserves stale drafts: softprops/action-gh-release creates a fresh draft then detects the existing draft for the same tag and keeps the old one while deleting the new one. generate_release_notes: true only applies at create time and never updates an existing draft body.

Changes

  • prepare-draft-release.yml: remove paths: [action.yml] — trigger on every push to main
  • prepare-draft-release.yml: add "Delete existing draft release" step before the softprops step — ensures a fresh draft with current generated notes is always created

Verification

  • actionlint .github/workflows/prepare-draft-release.yml: no errors
  • collateral check: clean
  • Behaviour: safe — the "Refuse to rewrite a published release" guard (already present) prevents any published release from being deleted; only draft releases are touched

Two issues prevented the draft release from tracking current state:

1. path filter 'paths: [action.yml]' meant that commits touching only
   scripts, workflows, or docs never triggered a draft refresh, so
   PRs merged after an action.yml-only window went unrecorded.

2. softprops/action-gh-release preserves an existing draft when it finds
   one for the same tag, keeping the body frozen at the first-create date.
   Adding an explicit delete step before the action ensures a fresh draft
   is always created with up-to-date generated notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant