fix(test-run-with-timeout-signals): use SCRIPT_DIR instead of cwd-relative path#87
Open
kitsuyui wants to merge 1 commit into
Open
fix(test-run-with-timeout-signals): use SCRIPT_DIR instead of cwd-relative path#87kitsuyui wants to merge 1 commit into
kitsuyui wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-run-with-timeout-signals.shcalledscripts/run-with-timeout.shas apath relative to the working directory. When the script is invoked from any
directory other than the repo root the lookup fails with "No such file or
directory", masking the actual signal-propagation test result.
Changes
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"afterset -euo pipefailscripts/run-with-timeout.shinvocation with"${SCRIPT_DIR}/run-with-timeout.sh"The test now finds
run-with-timeout.shregardless of the caller's workingdirectory, matching the robustness expected of a self-contained test script.
Testing
No functional change to the test logic. Verified with
shellcheck(clean) andshfmt -d(no format drift). The CItimeout-helperjob already runs fromrepo root and continues to work; the fix additionally handles non-root
cwdscenarios.