feat: add gitignore-version input for binary version override#103
Open
kitsuyui wants to merge 1 commit into
Open
feat: add gitignore-version input for binary version override#103kitsuyui wants to merge 1 commit into
kitsuyui wants to merge 1 commit into
Conversation
Previously the bundled gitignore-in binary version was hardcoded in the shell step with no way for callers to override it. This prevented testing pre-release binaries without forking the action. Add a gitignore-version input (kebab-case, aligning with existing outputs) with default v0.2.1. When the value matches the bundled version, SHA-256 integrity is verified as before. For any other value a GitHub Actions warning is emitted and verification is skipped. The README inputs table is extended with the new input and a naming- convention note explaining the snake_case / kebab-case split between existing inputs and outputs, with a pointer to the planned normalisation in a future major release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously the
gitignore-inbinary version was hardcoded inside the shellstep with no way for callers to override it. Users who wanted to test a
different binary version had to fork the action or pin to a specific SHA.
This PR adds a
gitignore-versioninput (default:v0.2.1) that allowscallers to specify which binary release to download. When the value matches
the bundled version, SHA-256 integrity is verified as before using
bundled-binary.sha256. For any other value a GitHub Actions warning isemitted and verification is skipped (intentional trade-off for pre-release
testing).
Changes
action.yml: addgitignore-versioninput; pass version through anenv:variable to avoid expression injection; add conditional SHA-256 check
README.md: document the new input; add a naming-convention note explainingthe current
snake_case/kebab-casesplit between existing inputs andoutputs, pointing to planned normalisation in a future major release
Verification
actionlint: no findingsgha-inline-script,version-shrink, ortoo-many-filesviolations)