fix(timeout): avoid false timeout marker after normal exit#102
Open
kitsuyui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/test-run-with-timeout.sh.Changes
scripts/run-with-timeout.shso timeout classification depends on successful signal delivery..github/workflows/main.ymlwith the shared test script.scripts/test-run-with-timeout.shfor timeout exit, command exit, and race regression coverage.Motivation
The watchdog previously treated a successful liveness probe as enough evidence to mark the command as timed out. If the command exited normally before the timeout signal was delivered, the wrapper could still report exit 124. This change makes the timeout marker reflect successful signal delivery instead.
Verification
go run mvdan.cc/sh/v3/cmd/shfmt@v3.13.1 -d scripts/*.shshellcheck scripts/*.shgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 -colortyposgit diff --checkbash -n scripts/*.shscripts/test-run-with-timeout.shbash scripts/test-run-with-timeout-signals.shscripts/test-run-with-timeout.shfails against the previousrun-with-timeout.shand passes on this branch.Notes
setsid; GitHub's Ubuntu runner providessetsid.