Skip to content

chore(ci): add GitHub Actions lockfile - #3459

Open
setchy wants to merge 1 commit into
mainfrom
chore/actions-lock
Open

setchy wants to merge 1 commit into
mainfrom
chore/actions-lock

Conversation

@setchy

@setchy setchy commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Summary

Adds a GitHub Actions lockfile generated with gh actions-lock. Every action used by the workflows (direct and transitive) is recorded with its verified commit SHA in .github/workflows/actions.lock.

  • Workflows reference readable version tags (e.g. actions/checkout@v7.0.1); the lockfile records the immutable SHA resolved for each ref.
  • Existing inline SHA pins in the workflows were consolidated into the lockfile.

Notes

  • Regenerate the lockfile after adding or changing any uses: with gh actions-lock.
  • Verify it in CI with gh actions-lock --verify.

Rollout considerations

gh actions-lock stores pins in the lockfile, so workflows move back to version tags. The org's current tooling still enforces inline SHA pinning:

  • Renovate (local>gitify-app/renovate-config → helpers:pinGitHubActionDigestsToSemver) will re-pin these refs on its next run.
  • zizmor's unpinned-uses audit flags tag refs.
  • SonarCloud rule githubactions:S7637 flags tag refs.

These tools do not understand lockfiles yet. Adopting this approach needs a policy decision: either relax those checks to ref-pin and rely on the lockfile, or keep inline SHA pins and use actions.lock as an additional record of transitive dependencies (gh actions-lock --verify accepts that state).

@setchy
setchy requested a review from afonsojramos as a code owner October 22, 2026 10:39

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zizmor found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions github-actions Bot added the chore Miscellaneous tasks label Oct 22, 2026
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Miscellaneous tasks

Development

Successfully merging this pull request may close these issues.

2 participants