Repository navigation
fix(graphql): support GitHub and Bitbucket schemas in the editor config - #3451
Merged
Merged
Conversation
Base automatically changed from
fix/graphql-codegen-plugin-resolution
to
main
October 17, 2026 04:01
github-actions
Bot
added
bug
graphql.config.ts pointed at a schema file codegen no longer produced and a documents directory that no longer exists, and the Bitbucket documents had no editor schema at all. - Rewrite graphql.config.ts as a multi-project config: a github project (local gitignored snapshot + GitHub documents) and a bitbucket project (public Atlassian gateway + Bitbucket documents). - Add a schema-ast output to codegen.ts so the GitHub snapshot is generated locally and stays gitignored (not committed). The Bitbucket schema comes from https://developer.atlassian.com/gateway/api/graphql (public, no credentials), matching setchy/atlassify. OpenSpec change: repair-graphql-lsp-config
setchy
force-pushed
the
fix/graphql-lsp-config
branch
from
October 17, 2026 12:26
b4f2839 to
bf2da31
Compare
setchy
changed the title
…generates entry Merging main into this branch nested the schema-ast output inside the Bitbucket output object, where a string key is not a valid property. The cache-disabled type check failed with TS2353 on that line. - Move the GitHub schema snapshot output to a sibling 'generates' entry, inside the GITHUB_TOKEN gate because it needs the GitHub schema. - Extract the shared GitHub schema pointer to a typed const so both GitHub outputs reference it.
|
Contributor
|
🎉 This pull request is included in Gitify v7.10.0! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Gitify better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
graphql.config.ts— read by the VS Code GraphQL extension — referenced a schema file codegen no longer produced and adocumentsglob in a directory that no longer existed. The Bitbucket GraphQL documents had no editor schema at all.What changed
graphql.config.tsis now a multi-project config:github: the locally generated GitHub SDL snapshot +src/renderer/utils/forges/github/**/*.graphqlbitbucket: the public Atlassian gatewayhttps://developer.atlassian.com/gateway/api/graphql(no credentials) +src/renderer/utils/forges/bitbucket/**/*.graphqlcodegen.ts: adds aschema-astoutput producing the GitHub snapshot atsrc/renderer/utils/forges/github/graphql/generated/schema.graphql.schema.graphql.Verification
pnpm codegenwrites the GitHub snapshot; git ignores it, nothing is tracked, and the working tree shows onlycodegen.ts+graphql.config.ts.graphql-configloads both projects:github: 1839 types resolved offline withGITHUB_TOKENunset, 5 scoped documents.bitbucket: 31,712 types resolved from the public gateway with no credentials; the fields/types the documents reference (me,notifications,InfluentsNotificationHeadItem,InfluentsNotificationReadState) are present.pnpm checkpasses.Notes
setchy/atlassifyuses, so no credentials are required.assumeValidin codegen. This affects node-based tooling; the editor ships its own bundled graphql version. Recorded as a design risk in the change.OpenSpec change:
repair-graphql-lsp-config