[log] Add debug logging to isEnclaveSession - #13602
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Adds debug log statements to internal/server/enclave_session.go to aid troubleshooting of enclave-scoped session detection. Reuses the existing logUnified logger (server:unified namespace) rather than creating a new one. - Logs when a session is identified as a delegated executor (enclave-scoped) - Logs the agent-policy-derived enclave decision for non-delegated sessions Session IDs are hashed via util.FormatSessionIDForLog before logging to avoid leaking raw identifiers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds debug logging to
internal/server/enclave_session.goto aid troubleshooting of enclave-scoped session detection.Changes
logUnifiedlogger (server:unifiednamespace) declared ininternal/server/unified.go— no new logger was created.util.FormatSessionIDForLogbefore logging to avoid leaking raw identifiers.Why this file
This was the smallest new (previously unprocessed) candidate file with zero existing logging calls, in a package with clear logging conventions already established (
logUnified). Most other candidate files ininternal/were already extensively logged.Validation
go vet ./internal/server/...— passedgo test ./internal/server/...— passed (ok)go build -o awmg .— passed, no compilation errorsNo side effects were introduced by the log arguments (only existing computed values and a pure formatting helper are passed).