Skip to content

Shared: Nicer panic message if node kind is missing #21815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 2 commits into from
May 13, 2026
+6 −5
Merged

Shared: Nicer panic message if node kind is missing #21815

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
638dc93
Shared: Nicer panic message if node kind is missing
asgerf May 7, 2026
9a1c2da
Fix clippy: inline variable in format string
asgerf May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Shared: Nicer panic message if node kind is missing 
Still panics, just with a better message
  • Loading branch information
@asgerf
asgerf committed May 8, 2026
commit 638dc9380c596ed0bdbd66b78495678b68d2c40a
11 changes: 6 additions & 5 deletions shared/tree-sitter-extractor/src/extractor/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,13 +479,14 @@ impl<'a> Visitor<'a> {
let (id, _, child_nodes) = self.stack.pop().expect("Vistor: empty stack");
Copy link
Copy Markdown
Contributor Author

@asgerf asgerf May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR

let loc = location_for(self, self.file_label, node);
let loc_label = location_label(self.trap_writer, loc);
let type_name = TypeName {
kind: node.kind().to_owned(),
named: node.is_named(),
};
let table = self
.schema
.get(&TypeName {
kind: node.kind().to_owned(),
named: node.is_named(),
})
.unwrap();
.get(&type_name)
.unwrap_or_else(|| panic!("missing extractor schema entry for {:?}", type_name));
let mut valid = true;
let parent_info = match self.stack.last_mut() {
Some(p) if !node.is_extra() => {
Expand Down
Loading